Fix offheap guard for OMR #7513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
approved these changes
Oct 31, 2024
rmnattas
approved these changes
Oct 31, 2024
|
Jenkins build plinux,aix |
|
@midronij : please see the CI build failures |
Use OMR_GC_SPARSE_HEAP_ALLOCATION instead of J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION in setmemoryEvaluator. Signed-off-by: midronij <[email protected]>
midronij
force-pushed
the
offheap-macro-fix
branch
from
d3e5330
to
60e18e3
Compare
|
Jenkins build plinux,aix |
|
I believe the CI failures are happening because my change is dependent on this PR: eclipse-openj9/openj9#20461. I've updated the title/description accordingly |
There should not ever be dependancy from OMR code on J9 (or potentially any other downstream project). OMR should be able to compile standalone. You might be missing some 'empty' methods in OMR that J9 fully implement |
|
for the failures of missing compressObjectReferences, follow an example of contiguousArrayHeaderSizeInBytes() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
OMR_GC_SPARSE_HEAP_ALLOCATIONinstead ofJ9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATIONinsetmemoryEvaluator().Depends on eclipse-openj9/openj9#20461